Labels Milestones

Improve signature check #611

Closed

Isira-Seneviratne wants to merge 1 commits from Isira-Seneviratne/Improve_signature_check into devel

pull from: Isira-Seneviratne/Improve_signature_check

merge into: KotatsuApp:devel

KotatsuApp:devel

KotatsuApp:master

KotatsuApp:weblate/weblate-kotatsu-strings

KotatsuApp:feature/double_reader

KotatsuApp:revert-444-Background_status_compat

KotatsuApp:feature/kitsu

Conversation 1 Commits 1 Files Changed 1

Isira-Seneviratne commented 2 years ago (Migrated from github.com)

Simplify the app signature check using PackageInfoCompat.hasSignatures().

Simplify the app signature check using [`PackageInfoCompat.hasSignatures()`](https://developer.android.com/reference/androidx/core/content/pm/PackageInfoCompat#hasSignatures(android.content.pm.PackageManager,java.lang.String,java.util.Map%3Cbyte[],java.lang.Integer%3E,boolean)).

Koitharu (Migrated from github.com) reviewed 2 years ago

Isira-Seneviratne (Migrated from github.com) reviewed 2 years ago

Koitharu (Migrated from github.com) reviewed 2 years ago

Isira-Seneviratne (Migrated from github.com) reviewed 2 years ago

Koitharu (Migrated from github.com) approved these changes 2 years ago

Koitharu commented 2 years ago (Migrated from github.com)

This one needs some testing, I'll merge it after the upcoming release

This one needs some testing, I'll merge it after the upcoming release

Koitharu closed this pull request 8 months ago

Reviewers

Koitharu

Please reopen this pull request to perform a merge.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b Isira-Seneviratne/Improve_signature_check devel

git pull origin Isira-Seneviratne/Improve_signature_check

Step 2:

Merge the changes and update on Gitea.

git checkout devel

git merge --no-ff Isira-Seneviratne/Improve_signature_check

git push origin devel

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Koitharu

Labels

Apply labels

Clear labels   

bug

Something isn't working   

documentation

Improvements or additions to documentation   

duplicate

This issue or pull request already exists   

enhancement

New feature or request   

feature request

  

help wanted

Extra attention is needed   

invalid

This doesn't seem right   

meta

  

question

Further information is requested   

scope:downloader

  

scope:reader

  

scope:tracker

  

upstream issue

  

ux

  

wontfix

This will not be worked on

No Label

bug

documentation

duplicate

enhancement

feature request

help wanted

invalid

meta

question

scope:downloader

scope:reader

scope:tracker

upstream issue

ux

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#611

Write Preview

Loading…

Cancel

Save

There is no content yet.