KotatsuApp/Kotatsu
2
0
Fork 0
Code Issues 124 Pull Requests Packages Projects Releases 163 Wiki Activity

Made some tweaks and implement splash screen #47

Closed
ztimms73 wants to merge 4 commits from tweaks into devel
pull from: tweaks
merge into: KotatsuApp:devel
Conversation 7 Commits 4 Files Changed 20 +129 -86
ztimms73 commented 2021-07-24 11:05:04 +00:00 (Migrated from github.com)
Copy Link
No description provided.
Koitharu commented 2021-07-24 15:31:10 +00:00 (Migrated from github.com)
Copy Link

Not sure about splash... I think, application start is enough fast and also should be optimized, instead of showing splash screen during initialization

Not sure about splash... I think, application start is enough fast and also should be optimized, instead of showing splash screen during initialization
ztimms73 commented 2021-07-24 19:10:51 +00:00 (Migrated from github.com)
Copy Link

Hmm. In general, splash screen does not particularly slow down the launch of the application (unless of course it is made on a timer, and using a timer for splash screen is a very bad idea). As for me, the application loads as quickly as without the splash screen. But, if you want, I can revert the commit

Hmm. In general, splash screen does not particularly slow down the launch of the application (unless of course it is made on a timer, and using a timer for splash screen is a very bad idea). As for me, the application loads as quickly as without the splash screen. But, if you want, I can revert the commit
Koitharu commented 2021-07-25 01:13:21 +00:00 (Migrated from github.com)
Copy Link

I will see it later

I will see it later
ztimms73 commented 2021-07-25 16:04:16 +00:00 (Migrated from github.com)
Copy Link

This commit improves the visual appearance of the bottom sheet, and when the RecyclerView is scrolled, a shadow appears under the toolbar

Not expanded Expanded Scrolled
Screenshot_1627228691 Screenshot_1627228696 Screenshot_1627228795
This commit improves the visual appearance of the bottom sheet, and when the RecyclerView is scrolled, a shadow appears under the toolbar |Not expanded|Expanded|Scrolled| |-----|-----|-----| |![Screenshot_1627228691](https://user-images.githubusercontent.com/61558546/126905587-0fd66d43-0e83-4c26-9593-69eea8e6ba1d.png)|![Screenshot_1627228696](https://user-images.githubusercontent.com/61558546/126905604-ef08404b-f431-46d5-bac9-9cd48afd5104.png)|![Screenshot_1627228795](https://user-images.githubusercontent.com/61558546/126905617-2c2b52ab-112e-445a-9fbe-18ab355ac501.png)
👍 1
Koitharu (Migrated from github.com) reviewed 2021-07-28 05:16:27 +00:00
Koitharu commented 2021-07-28 05:19:54 +00:00 (Migrated from github.com)
Copy Link

splash screen

Let leave Splash screen only for api >= 23 and don`t add raster images, because they needed only for splash at api < 23 (as I can see)

> splash screen Let leave Splash screen only for api >= 23 and don`t add raster images, because they needed only for splash at api < 23 (as I can see)
ztimms73 commented 2021-07-29 19:24:20 +00:00 (Migrated from github.com)
Copy Link

So, I had to abandon the splash screen, because when testing on Lollipop, there was no basic splash screen (when you click on the icon, nothing happens, time passes and MainActivity loads, i.e. there is no splash screen), at the same time, on SDK >= 23, a splash screen appears, I thought to make a stub for SDK < 23, but I decided that this was a bad idea. Maybe we will return it when the time comes to raise the Android version to 23. I am also forced to close PR, as I have encountered some difficulties in resolving conflicts...

So, I had to abandon the splash screen, because when testing on Lollipop, there was no basic splash screen (when you click on the icon, nothing happens, time passes and MainActivity loads, i.e. there is no splash screen), at the same time, on SDK >= 23, a splash screen appears, I thought to make a stub for SDK < 23, but I decided that this was a bad idea. Maybe we will return it when the time comes to raise the Android version to 23. I am also forced to close PR, as I have encountered some difficulties in resolving conflicts...

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Koitharu
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 meta
question
Further information is requested
 scope:downloader
scope:reader
scope:tracker
upstream issue
ux
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Koitharu Xtimms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#47
Delete Branch "tweaks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?