Improve ListHeader #442

Merged

Isira-Seneviratne merged 2 commits from ListHeader_improvements into devel 2023-08-02 07:06:27 +00:00

Conversation 8 Commits 2 Files Changed 8 +20 -47

Isira-Seneviratne commented 2023-08-01 01:41:30 +00:00 (Migrated from github.com)

Copy Link

No description provided.

Koitharu (Migrated from github.com) reviewed 2023-08-01 08:58:16 +00:00

Isira-Seneviratne (Migrated from github.com) reviewed 2023-08-01 08:59:53 +00:00

Koitharu (Migrated from github.com) reviewed 2023-08-01 09:03:34 +00:00

Isira-Seneviratne (Migrated from github.com) reviewed 2023-08-01 09:06:04 +00:00

Koitharu (Migrated from github.com) reviewed 2023-08-01 09:06:07 +00:00

Koitharu commented 2023-08-01 09:55:00 +00:00 (Migrated from github.com)

Copy Link

So, I converted 10 classes to data and removed manually generated equals/hashCode
Before conversion:

With data classes:

The difference is 10 methods
Looks like copy() and componentN() functions are absent, but toString() is present

So, I think, it is ok to use data classes (ofc, it may consume a bit more time at compilation stage, but this is insignificant), thank you for this

So, I converted 10 classes to `data` and removed manually generated `equals`/`hashCode` Before conversion:  With data classes:  The difference is 10 methods Looks like `copy()` and `componentN()` functions are absent, but `toString()` is present  So, I think, it is ok to use `data` classes (ofc, it may consume a bit more time at compilation stage, but this is insignificant), thank you for this

Koitharu (Migrated from github.com) reviewed 2023-08-01 09:59:27 +00:00

Koitharu (Migrated from github.com) approved these changes 2023-08-02 04:41:22 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Isira-Seneviratne

Koitharu

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

feature request

help wanted

Extra attention is needed

invalid

This doesn't seem right

meta

question

Further information is requested

scope:downloader

scope:reader

scope:tracker

upstream issue

ux

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Koitharu Xtimms

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#442