Backup settings #421

2023-07-15T22:08:47Z

javlonrahimov commented

2023-07-15 22:08:47 +00:00

(Migrated from github.com)

When doing backup, the app was exporting history, categories and favorites.
In this commit, the support for saving settings is added.

Settings below are omitted:

proxy_login and proxy_password : for security reasons
incognito_mode : as it isn't usually turned on
app_password : the user may have forgotten the password

I added some utility functions in some files, if it is wasn't aligned with the clean code principles, I can refactor the code 🙂

When doing backup, the app was exporting history, categories and favorites. In this commit, the support for saving `settings` is added. Settings below are omitted: - `proxy_login` and `proxy_password` : for security reasons - `incognito_mode` : as it isn't usually turned on - `app_password` : the user may have forgotten the password I added some utility functions in some files, if it is wasn't aligned with the clean code principles, I can refactor the code 🙂

Koitharu commented

2023-07-16 05:26:24 +00:00

(Migrated from github.com)

Looks fine, I'll review it as soon as I will have some free time, thank you

Koitharu commented

2023-07-17 10:26:08 +00:00

(Migrated from github.com)

This approach has one significant cons: new settings should be added manually and it is very easy to forget about this.

So I propose a bit different approach: get all values from SharedPreferences and covert it into json and vise versa

This approach has one significant cons: new settings should be added manually and it is very easy to forget about this. So I propose a bit different approach: get all values from SharedPreferences and covert it into json and vise versa

👍 1

Koitharu (Migrated from github.com) approved these changes 2023-07-18 08:53:43 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#421