KotatsuApp/Kotatsu
2
0
Fork 0
Code Issues 124 Pull Requests Packages Projects Releases 163 Wiki Activity

Redesign UI #33

Merged
ztimms73 merged 10 commits from redesign into devel 2021-06-18 04:35:45 +00:00
Conversation 11 Commits 10 Files Changed 118 +2981 -787
ztimms73 commented 2021-06-16 22:44:16 +00:00 (Migrated from github.com)
Copy Link

The work on changing the interface is complete. The application was tested on API 21, 23, 29 and no bugs were found in the interface. Here is a table with screenshots of the old and new versions for comparison.

Old New
Screenshot_1623880672 Screenshot_1623880963
Screenshot_1623880680 Screenshot_1623880971
Screenshot_1623880692 Screenshot_1623880977
Screenshot_1623880696 Screenshot_1623880982
Screenshot_1623880733 Screenshot_1623881011
Screenshot_1623880737 Screenshot_1623881015
Screenshot_1623880744 Screenshot_1623881022
Screenshot_1623880775 Screenshot_1623881038
Local manga Remote manga
Screenshot_1623881038 Screenshot_1623881105
Tablet portrait (Nexus 7 (2013)) Tablet landscape (Nexus 7 (2013))
Screenshot_1623881439 Screenshot_1623881425
The work on changing the interface is complete. The application was tested on API 21, 23, 29 and no bugs were found in the interface. Here is a table with screenshots of the old and new versions for comparison. | Old | New | | ------------- | ------------- | | ![Screenshot_1623880672](https://user-images.githubusercontent.com/61558546/122301541-79cc0080-cf09-11eb-9ce0-27a16f6452dd.png) | ![Screenshot_1623880963](https://user-images.githubusercontent.com/61558546/122301584-8c463a00-cf09-11eb-97f0-7e9cfd41c4c1.png) | | ![Screenshot_1623880680](https://user-images.githubusercontent.com/61558546/122301720-c0215f80-cf09-11eb-863b-de6635278523.png) | ![Screenshot_1623880971](https://user-images.githubusercontent.com/61558546/122301747-ca435e00-cf09-11eb-809d-6b105e42eaa3.png) | | ![Screenshot_1623880692](https://user-images.githubusercontent.com/61558546/122301831-ea731d00-cf09-11eb-9e2b-120382490add.png) | ![Screenshot_1623880977](https://user-images.githubusercontent.com/61558546/122301861-f52db200-cf09-11eb-8968-e299725fddaf.png) | | ![Screenshot_1623880696](https://user-images.githubusercontent.com/61558546/122301928-10002680-cf0a-11eb-8204-44aaa2510c3e.png) | ![Screenshot_1623880982](https://user-images.githubusercontent.com/61558546/122301946-18586180-cf0a-11eb-864a-0c8893c1b514.png) | | ![Screenshot_1623880733](https://user-images.githubusercontent.com/61558546/122302036-3a51e400-cf0a-11eb-92a3-80278717ae7b.png) | ![Screenshot_1623881011](https://user-images.githubusercontent.com/61558546/122302070-45a50f80-cf0a-11eb-9fae-a0d02808765a.png) | | ![Screenshot_1623880737](https://user-images.githubusercontent.com/61558546/122302103-52296800-cf0a-11eb-886b-77186f2d4a4d.png) | ![Screenshot_1623881015](https://user-images.githubusercontent.com/61558546/122302121-58b7df80-cf0a-11eb-9df6-8bedf67fd09d.png) | | ![Screenshot_1623880744](https://user-images.githubusercontent.com/61558546/122302274-8b61d800-cf0a-11eb-93de-38fcd51d2443.png) | ![Screenshot_1623881022](https://user-images.githubusercontent.com/61558546/122302299-93217c80-cf0a-11eb-88ea-0e545a8b612d.png) | | ![Screenshot_1623880775](https://user-images.githubusercontent.com/61558546/122302445-ccf28300-cf0a-11eb-9868-ca2406d1e35a.png) | ![Screenshot_1623881038](https://user-images.githubusercontent.com/61558546/122302477-d67beb00-cf0a-11eb-8330-d9b6b2b95e2b.png) | | Local manga | Remote manga | | ------------- | ------------- | | ![Screenshot_1623881038](https://user-images.githubusercontent.com/61558546/122302789-45594400-cf0b-11eb-87a3-857db2bc66ab.png) | ![Screenshot_1623881105](https://user-images.githubusercontent.com/61558546/122302819-4d18e880-cf0b-11eb-89b2-2b593af45d67.png) | | Tablet portrait (Nexus 7 (2013)) | Tablet landscape (Nexus 7 (2013)) | | ------------- | ------------- | | ![Screenshot_1623881439](https://user-images.githubusercontent.com/61558546/122303077-a2ed9080-cf0b-11eb-891d-11f007be70ab.png) | ![Screenshot_1623881425](https://user-images.githubusercontent.com/61558546/122303196-d3cdc580-cf0b-11eb-9977-efef8dccac08.png) |
Koitharu commented 2021-06-17 07:59:55 +00:00 (Migrated from github.com)
Copy Link

Looks very good, I'll review it when I'm at home. Also, what about new search ui?

Looks very good, I'll review it when I'm at home. Also, what about new search ui?
ztimms73 commented 2021-06-17 09:28:37 +00:00 (Migrated from github.com)
Copy Link

@nv95, are you talking about the SearchUI that you made 2 weeks ago, or about the MaterialSearchView that I tried to implement? If about MaterialSearchView, then I need to think about how to replace the Toolbar with this. MaterialSearchView has a flaw, it can't inflate menu items, so I modified it a bit and added OnMenuItemClickListener. Also, I need to think about how to link it with SearchUI. You can read more about MaterialSearchView here.

@nv95, are you talking about the SearchUI that you made 2 weeks ago, or about the MaterialSearchView that I tried to implement? If about MaterialSearchView, then I need to think about how to replace the Toolbar with this. MaterialSearchView has a flaw, it can't inflate menu items, so I modified it a bit and added `OnMenuItemClickListener`. Also, I need to think about how to link it with SearchUI. You can read more about MaterialSearchView [here](https://github.com/lapism/search).
Koitharu commented 2021-06-17 09:54:00 +00:00 (Migrated from github.com)
Copy Link

Ok, let's merge this firstly.
Maybe it will be better to implement ui like MaterialSearchView without this library using ActionMenuView (from androidx) for option menu

Ok, let's merge this firstly. Maybe it will be better to implement ui like MaterialSearchView without this library using ActionMenuView (from androidx) for option menu
Koitharu (Migrated from github.com) reviewed 2021-06-17 17:54:38 +00:00
Koitharu (Migrated from github.com) reviewed 2021-06-17 17:59:43 +00:00
ztimms73 (Migrated from github.com) reviewed 2021-06-17 19:23:42 +00:00
ztimms73 (Migrated from github.com) reviewed 2021-06-17 19:23:50 +00:00
ztimms73 (Migrated from github.com) reviewed 2021-06-17 19:24:11 +00:00
ztimms73 commented 2021-06-17 20:43:12 +00:00 (Migrated from github.com)
Copy Link

How can I resolve conflicts?

How can I resolve conflicts?
ztimms73 (Migrated from github.com) reviewed 2021-06-18 00:40:33 +00:00
Koitharu (Migrated from github.com) reviewed 2021-06-18 04:27:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ztimms73
Koitharu
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 meta
question
Further information is requested
 scope:downloader
scope:reader
scope:tracker
upstream issue
ux
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Koitharu Xtimms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#33
Delete Branch "redesign"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?