Remove DUMMY parser

CONTRIBUTING.md

@@ -63,12 +63,14 @@ All members of the `MangaParser` class are documented. Pay attention to some pec
 - You can use _asserts_ to check some optional fields. For example, the `Manga.author` field is not required, but if
   your source provides this information, add `assert(it != null)`. This will not have any effect on production but help
   to find issues during unit testing.
+- Your parser may also implement the `Interceptor` interface for additional manipulation of all network requests and
+  responses, including image loading.
 - If your source website (or its API) uses pages for pagination instead of offset you should extend `PagedMangaParser`
   instead of `MangaParser`.
 - If your source website (or its API) does not provide pagination (has only one page of content) you should extend
   `SinglePageMangaParser` instead of `MangaParser` or `PagedMangaParser`.
-- Your parser may also implement the `Interceptor` interface for additional manipulation of all network requests and
-  responses, including image loading.
+
+![parser_classes.png](docs/parser_classes.png)
 
 ## Development process
 

README.md

@@ -53,11 +53,9 @@ JVM and Android applications.
    `mangaLoaderContext` is an implementation of the `MangaLoaderContext` class.
    See examples
    of [Android](https://github.com/KotatsuApp/Kotatsu/blob/devel/app/src/main/kotlin/org/koitharu/kotatsu/core/parser/MangaLoaderContextImpl.kt)
-   and [Non-Android](https://github.com/KotatsuApp/kotatsu-dl/blob/master/src/jvmMain/kotlin/org/koitharu/kotatsu_dl/logic/MangaLoaderContextImpl.kt)
+   and [Non-Android](https://github.com/KotatsuApp/kotatsu-dl/blob/master/src/main/kotlin/org/koitharu/kotatsu/dl/parsers/MangaLoaderContextImpl.kt)
    implementation.
 
-   Note that the `MangaParserSource.DUMMY` parsers cannot be instantiated.
-
 ## Projects that use the library
 
 - [Kotatsu](https://github.com/KotatsuApp/Kotatsu)

kotatsu-parsers-ksp/src/main/kotlin/org/koitharu/kotatsu/parsers/ksp/ParserProcessor.kt

@@ -98,7 +98,6 @@ class ParserProcessor(
 
         factoryWriter?.write(
             """
-				MangaParserSource.DUMMY -> throw NotImplementedError("Manga parser ${'$'}name cannot be instantiated")
 			}.let {
 				require(it.source == this) {
 					"Cannot instantiate manga parser: ${'$'}name mapped to ${'$'}{it.source}"
@@ -109,7 +108,6 @@ class ParserProcessor(
         )
         sourcesWriter?.write(
             """
-				DUMMY("Dummy", "", ContentType.OTHER, false),
 				;
 			}
 			""".trimIndent(),

src/test/kotlin/org/koitharu/kotatsu/parsers/MangaSources.kt

@@ -1,8 +1,8 @@
 package org.koitharu.kotatsu.parsers
 
 import org.junit.jupiter.params.provider.EnumSource
-import org.junit.jupiter.params.provider.EnumSource.Mode.EXCLUDE
 import org.koitharu.kotatsu.parsers.model.MangaParserSource
 
-@EnumSource(MangaParserSource::class, names = ["DUMMY"], mode = EXCLUDE)
+// Change 'names' to test specified parsers
+@EnumSource(MangaParserSource::class, names = [], mode = EnumSource.Mode.INCLUDE)
 internal annotation class MangaSources

src/test/kotlin/org/koitharu/kotatsu/parsers/model/search/MangaSearchQueryTest.kt

@@ -68,5 +68,5 @@ class MangaSearchQueryCapabilitiesTest {
         assertThrows(IllegalArgumentException::class.java) { capabilities.validate(query) }
     }
 
-	private fun buildTag(name: String) = MangaTag(title = name, key = "${name}Key", source = MangaParserSource.DUMMY)
+    private fun buildTag(name: String) = MangaTag(title = name, key = "${name}Key", source = MangaParserSource.MANGADEX)
 }

src/test/kotlin/org/koitharu/kotatsu/parsers/util/IntentFilterGenerator.kt

@@ -22,9 +22,6 @@ class IntentFilterGenerator {
             writer.appendTab().appendLine("<data android:scheme=\"https\" />")
             writer.appendLine()
             for (source in MangaParserSource.entries) {
-				if (source == MangaParserSource.DUMMY) {
-					continue
-				}
                 val parser = source.newParser(MangaLoaderContextMock)
                 parser.configKeyDomain.presetValues.forEach { domain ->
                     writer.appendTab().append("<data android:host=\"").append(domain).appendLine("\" />")

src/test/kotlin/org/koitharu/kotatsu/parsers/util/ListFilterToSearchQueryConverterTest.kt

@@ -71,7 +71,7 @@ class ListFilterToSearchQueryConverterTest {
         return MangaTag(
             key = "${name}Key",
             title = name,
-			source = MangaParserSource.DUMMY,
+            source = MangaParserSource.MANGADEX,
         )
     }
 }

src/test/kotlin/org/koitharu/kotatsu/parsers/util/SearchQueryToListFilterConverterTest.kt

@@ -88,7 +88,7 @@ class ConvertToMangaListFilterTest {
         return MangaTag(
             key = "${name}Key",
             title = name,
-			source = MangaParserSource.DUMMY,
+            source = MangaParserSource.MANGADEX,
         )
     }
 }