Enhance download cancellation in blocking io tasks #90

app/src/main/java/org/koitharu/kotatsu/download/domain/DownloadManager.kt

@@ -145,7 +145,7 @@ class DownloadManager(
 		while (true) {
 			try {
 				val response = call.clone().await()
-				withContext(Dispatchers.IO) {
+				runInterruptible(Dispatchers.IO) {
 					file.outputStream().use { out ->
 						checkNotNull(response.body).byteStream().copyTo(out)
 					}

app/src/main/java/org/koitharu/kotatsu/local/data/MangaZip.kt

@@ -31,7 +31,7 @@ class MangaZip(val file: File) {
 		return writableCbz.flush()
 	}
 
-	fun addCover(file: File, ext: String) {
+	suspend fun addCover(file: File, ext: String) {
 		val name = buildString {
 			append(FILENAME_PATTERN.format(0, 0))
 			if (ext.isNotEmpty() && ext.length <= 4) {
@@ -39,11 +39,11 @@ class MangaZip(val file: File) {
 				append(ext)
 			}
 		}
-		writableCbz[name] = file
+		writableCbz.put(name, file)
 		index.setCoverEntry(name)
 	}
 
-	fun addPage(chapter: MangaChapter, file: File, pageNumber: Int, ext: String) {
+	suspend fun addPage(chapter: MangaChapter, file: File, pageNumber: Int, ext: String) {
 		val name = buildString {
 			append(FILENAME_PATTERN.format(chapter.number, pageNumber))
 			if (ext.isNotEmpty() && ext.length <= 4) {
@@ -51,7 +51,7 @@ class MangaZip(val file: File) {
 				append(ext)
 			}
 		}
-		writableCbz[name] = file
+		writableCbz.put(name, file)
 		index.addChapter(chapter)
 	}
 

app/src/main/java/org/koitharu/kotatsu/local/data/WritableCbzFile.kt

@@ -1,8 +1,7 @@
 package org.koitharu.kotatsu.local.data
 
 import androidx.annotation.CheckResult
-import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.*
-import kotlinx.coroutines.withContext
 import java.io.File
 import java.io.FileInputStream
 import java.io.FileOutputStream
@@ -27,12 +26,14 @@ class WritableCbzFile(private val file: File) {
 		}
 		ZipInputStream(FileInputStream(file)).use { zip ->
 			var entry = zip.nextEntry
-			while (entry != null) {
+			while (entry != null && currentCoroutineContext().isActive) {
 				val target = File(dir.path + File.separator + entry.name)
+				runInterruptible {
 					target.parentFile?.mkdirs()
 					target.outputStream().use { out ->
 						zip.copyTo(out)
 					}
+				}
 				zip.closeEntry()
 				entry = zip.nextEntry
 			}
@@ -51,12 +52,14 @@ class WritableCbzFile(private val file: File) {
 			tempFile.delete()
 		}
 		try {
+			runInterruptible {
 				ZipOutputStream(FileOutputStream(tempFile)).use { zip ->
 					dir.listFiles()?.forEach {
 						zipFile(it, it.name, zip)
 					}
 					zip.flush()
 				}
+			}
 			tempFile.renameTo(file)
 		} finally {
 			if (tempFile.exists()) {
@@ -67,12 +70,10 @@ class WritableCbzFile(private val file: File) {
 
 	operator fun get(name: String) = File(dir, name)
 
-	operator fun set(name: String, file: File) {
+	suspend fun put(name: String, file: File) = runInterruptible(Dispatchers.IO) {
 		file.copyTo(this[name], overwrite = true)
 	}
 
-	companion object {
-
 	private fun zipFile(fileToZip: File, fileName: String, zipOut: ZipOutputStream) {
 		if (fileToZip.isDirectory) {
 			if (fileName.endsWith("/")) {
@@ -92,5 +93,4 @@ class WritableCbzFile(private val file: File) {
 			}
 		}
 	}
-	}
 }