From 7907b3126cc72506e6ef913a4b9686a2f4897da4 Mon Sep 17 00:00:00 2001 From: ViAnh <37103340+VietAnh14@users.noreply.github.com> Date: Mon, 24 Oct 2022 23:29:53 +0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Koitharu --- .../org/koitharu/kotatsu/parsers/site/Manhwa18Parser.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/kotlin/org/koitharu/kotatsu/parsers/site/Manhwa18Parser.kt b/src/main/kotlin/org/koitharu/kotatsu/parsers/site/Manhwa18Parser.kt index dc29a337..5f6da4c7 100644 --- a/src/main/kotlin/org/koitharu/kotatsu/parsers/site/Manhwa18Parser.kt +++ b/src/main/kotlin/org/koitharu/kotatsu/parsers/site/Manhwa18Parser.kt @@ -106,14 +106,14 @@ class Manhwa18Parser(override val context: MangaLoaderContext) : PagedMangaParse } val sortType = if (sortOrder == SortOrder.ALPHABETICAL) "ASC" else "DESC" - val tagQuery = tags.orEmpty().joinToString(",") { it.key } + val tagQuery = tags?.joinToString(",") { it.key }.orEmpty() val url = buildString { append("https://") append(getDomain()) append("/manga-list.html?listType=pagination&page=") append(page) append("&artist=&author=&group=&m_status=&name=") - append(query.orEmpty()) + append(query?.urlEncoded().orEmpty()) append("&genre=$tagQuery") append("&ungenre=") append("&sort=") @@ -167,7 +167,7 @@ class Manhwa18Parser(override val context: MangaLoaderContext) : PagedMangaParse } override suspend fun getTags(): Set { - return context.httpGet("https://${getDomain()}/").parseHtml().selectFirst(".genres-menu") + return context.httpGet("https://${getDomain()}/").parseHtml().selectFirstOrThrow(".genres-menu") ?.select("a.genres-item").orEmpty() .mapToSet { MangaTag(