From 704a063cb3aedf43810a9c2af5f587f756db05e9 Mon Sep 17 00:00:00 2001 From: ViAnh <37103340+VietAnh14@users.noreply.github.com> Date: Fri, 2 Sep 2022 17:44:36 +0700 Subject: [PATCH] [NetTruyen] Apply suggestions from code review Co-authored-by: Koitharu --- .../org/koitharu/kotatsu/parsers/site/NetTruyenParser.kt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/kotlin/org/koitharu/kotatsu/parsers/site/NetTruyenParser.kt b/src/main/kotlin/org/koitharu/kotatsu/parsers/site/NetTruyenParser.kt index f5719c1d..afe0671e 100644 --- a/src/main/kotlin/org/koitharu/kotatsu/parsers/site/NetTruyenParser.kt +++ b/src/main/kotlin/org/koitharu/kotatsu/parsers/site/NetTruyenParser.kt @@ -108,7 +108,10 @@ class NetTruyenParser(override val context: MangaLoaderContext) : append("https://") append(getDomain()) if (isSearching) { - append("/tim-truyen?keyword=$query&page=$page") + append("/tim-truyen?keyword=) + append(query.urlEncoded()) + append("&page=") + append(page) } else { val tagQuery = tags.orEmpty().joinToString(",") { it.key } append("/tim-truyen-nang-cao?genres=$tagQuery") @@ -134,7 +137,7 @@ class NetTruyenParser(override val context: MangaLoaderContext) : .select("div.item") return itemsElements.mapNotNull { item -> val tooltipElement = item.selectFirst("div.box_tootip") ?: return@mapNotNull null - val absUrl = item.selectFirst("div.image > a")?.attr("href") ?: return@mapNotNull null + val absUrl = item.selectFirst("div.image > a")?.attrAsAbsoluteUrlOrNull("href") ?: return@mapNotNull null val slug = absUrl.substringAfterLast('/') val mangaState = when (tooltipElement.selectFirst("div.message_main > p:contains(Tình trạng)")?.ownText()) { "Đang tiến hành" -> MangaState.ONGOING @@ -170,7 +173,7 @@ class NetTruyenParser(override val context: MangaLoaderContext) : val pageElements = context.httpGet(chapter.url.toAbsoluteUrl(getDomain())).parseHtml() .select("div.reading-detail.box_doc > div img") return pageElements.map { element -> - val url = element.absUrl("data-original") + val url = element.attrAsAbsoluteUrl("data-original") MangaPage( id = generateUid(url), url = url,