KotatsuApp/Kotatsu
2
0
Fork 0
Code Issues 124 Pull Requests Packages Projects Releases 163 Wiki Activity

Material 3 #84

Merged
ztimms73 merged 7 commits from m3 into devel 2022-01-28 15:44:20 +00:00
Conversation 4 Commits 7 Files Changed 121 +722 -637
ztimms73 commented 2022-01-16 15:06:47 +00:00 (Migrated from github.com)
Copy Link

TODO:

  • Remove legacy AlertDialogs
  • Try to use canonical layouts (later)
  • Implement dynamic theme option

Screenshots:

Screenshot_1642345065 Screenshot_1642345094 Screenshot_1642345098
Screenshot_1642345251 Screenshot_1642345249 Screenshot_1642345254
TODO: - [x] Remove legacy AlertDialogs - [ ] ~~Try to use [canonical layouts](https://m3.material.io/libraries/mdc-android/canonical-layouts)~~ (later) - [x] Implement dynamic theme option Screenshots: | ![Screenshot_1642345065](https://user-images.githubusercontent.com/61558546/149665519-39ea92fe-6c77-40b8-b772-81062dc9de4b.png) | ![Screenshot_1642345094](https://user-images.githubusercontent.com/61558546/149665528-7be4ba0a-6b46-416c-91a1-ea6a23079765.png) | ![Screenshot_1642345098](https://user-images.githubusercontent.com/61558546/149665534-06d085ed-77a3-44a4-983a-b9d1b0d68350.png) | |---|---|---| | ![Screenshot_1642345251](https://user-images.githubusercontent.com/61558546/149665612-99b77a09-a683-4df5-b1a7-ebaf4be53cc3.png) | ![Screenshot_1642345249](https://user-images.githubusercontent.com/61558546/149665590-f3527dbb-7d60-4a9c-856e-0410941ab61b.png) | ![Screenshot_1642345254](https://user-images.githubusercontent.com/61558546/149665618-402f5786-7dd1-4c0c-9b3a-7b921f6ec932.png) |
Koitharu commented 2022-01-16 17:16:15 +00:00 (Migrated from github.com)
Copy Link

Cannot find any guidelines for tabs. I think, it should be redesigned too

Cannot find any guidelines for tabs. I think, it should be redesigned too
Koitharu (Migrated from github.com) reviewed 2022-01-16 17:28:50 +00:00
ztimms73 commented 2022-01-16 20:13:58 +00:00 (Migrated from github.com)
Copy Link

Cannot find any guidelines for tabs. I think, it should be redesigned too

While there was the Material 2 era, the TabLayout style was like Material 1 and some applications, including Kotatsu, took the TabLayout style from Google apps. And only then, a built-in TabLayout style like Google apps appeared in Material 3, so I removed some attributes like tabIndicator and tabTextAppearance from the Widget.Kotatsu.Tabs style

> Cannot find any guidelines for tabs. I think, it should be redesigned too While there was the Material 2 era, the TabLayout style was like Material 1 and some applications, including Kotatsu, took the TabLayout style from Google apps. And only then, a built-in TabLayout style like Google apps appeared in Material 3, so I removed some attributes like `tabIndicator` and `tabTextAppearance` from the `Widget.Kotatsu.Tabs` style
Koitharu (Migrated from github.com) approved these changes 2022-01-28 15:43:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Koitharu
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 meta
question
Further information is requested
 scope:downloader
scope:reader
scope:tracker
upstream issue
ux
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Koitharu Xtimms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#84
Delete Branch "m3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?