KotatsuApp/Kotatsu
2
0
Fork 0
Code Issues 124 Pull Requests Packages Projects Releases 163 Wiki Activity

color correction bug #597

New Issue
Closed
opened 2023-12-17 11:12:54 +00:00 by sinjoe · 2 comments
sinjoe commented 2023-12-17 11:12:54 +00:00 (Migrated from github.com)
Copy Link

Brief summary

"This manga" and "Globally" option is swap.
Choosing "Globally" only affect current manga. Choosing "This manga" affect global.

cc ui

Steps to reproduce

  1. Open color correction
  2. Pick "Globally"
  3. Only affect current manga
  4. Pick "This manga"
  5. Affect all manga

Kotatsu version

6.5

Android version

10

Device

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • If this is an issue with a parser, I should be opening an issue in the parsers repository.
### Brief summary "This manga" and "Globally" option is swap. Choosing "Globally" only affect current manga. Choosing "This manga" affect global. ![cc ui](https://github.com/KotatsuApp/Kotatsu/assets/141518184/2343ab89-6975-4b73-8449-f581ca55195b) ### Steps to reproduce 1. Open color correction 2. Pick "Globally" 3. Only affect current manga 4. Pick "This manga" 5. Affect all manga ### Kotatsu version 6.5 ### Android version 10 ### Device _No response_ ### Acknowledgements - [X] I have searched the existing issues and this is a new ticket, **NOT** a duplicate or related to another open issue. - [X] If this is an issue with a parser, I should be opening an issue in the [parsers repository](https://github.com/KotatsuApp/kotatsu-parsers/issues/new/choose).
sinjoe commented 2023-12-17 11:46:24 +00:00 (Migrated from github.com)
Copy Link

Also resetting color correction is somewhat bugged?

Step to reproduce

  1. Open manga
  2. Color correction
  3. Choose this manga (currently named globally)
  4. Save
  5. Open different manga
  6. Reset, choose global (currently named This manga)
  7. Save
  8. Go back to previous manga, color correction doesn't reset.

Resetting works correctly if global (this manga) is chosen from the beginning.

Also resetting color correction is somewhat bugged? Step to reproduce 1. Open manga 2. Color correction 3. Choose this manga (currently named globally) 4. Save 5. Open different manga 6. Reset, choose global (currently named This manga) 7. Save 8. Go back to previous manga, color correction doesn't reset. Resetting works correctly if global (this manga) is chosen from the beginning.
sinjoe commented 2023-12-22 11:33:28 +00:00 (Migrated from github.com)
Copy Link

Color correction naming is fixed now in 6.5.1, Thanks.

Color correction naming is fixed now in 6.5.1, Thanks.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 meta
question
Further information is requested
 scope:downloader
scope:reader
scope:tracker
upstream issue
ux
wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Koitharu Xtimms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?