KotatsuApp/Kotatsu
2
0
Fork 0
Code Issues 124 Pull Requests Packages Projects Releases 163 Wiki Activity

Fix Remanga sort, new manga source Anibel, UI changes #30

Merged
ztimms73 merged 8 commits from sources into devel 2021-05-17 16:48:52 +00:00
Conversation 6 Commits 8 Files Changed 14 +203 -6
ztimms73 commented 2021-05-15 07:32:37 +00:00 (Migrated from github.com)
Copy Link

That commit closes issue #28, adds new manga source Anibel, adds option to hide or not toolbar in app settings and edits cards appearance

That commit closes issue #28, adds new manga source Anibel, adds option to hide or not toolbar in app settings and edits cards appearance
Koitharu (Migrated from github.com) reviewed 2021-05-15 16:37:06 +00:00
app/src/main/java/org/koitharu/kotatsu/core/parser/site/AnibelRepository.kt
Koitharu (Migrated from github.com) commented 2021-05-15 16:21:14 +00:00
Copy Link

offset or page?

`offset` or `page`?
Koitharu (Migrated from github.com) commented 2021-05-15 16:23:59 +00:00
Copy Link
			val href = card.selectFirst("a").attr("href")

`

```suggestion val href = card.selectFirst("a").attr("href") ``` `
Koitharu (Migrated from github.com) commented 2021-05-15 16:25:42 +00:00
Copy Link

Url should be relative, without host. Host will adds every time in getDetails

Url should be relative, without host. Host will adds every time in `getDetails`
Koitharu (Migrated from github.com) commented 2021-05-15 16:27:13 +00:00
Copy Link

largeCoverUrl may be null, then coverUrl will be used

`largeCoverUrl` may be null, then `coverUrl` will be used
Koitharu (Migrated from github.com) commented 2021-05-15 16:30:09 +00:00
Copy Link

Same thing, url must be relative, because user can change domain in preferences and it should be applied to manga from history or favorites.

				val href = a.select("a").first().attr("href").toRelativeUrl(getDomain())
Same thing, url must be relative, because user can change domain in preferences and it should be applied to manga from history or favorites. ```suggestion val href = a.select("a").first().attr("href").toRelativeUrl(getDomain()) ```
Koitharu (Migrated from github.com) commented 2021-05-15 16:33:48 +00:00
Copy Link
				url = href,
```suggestion url = href, ```
Koitharu (Migrated from github.com) commented 2021-05-15 16:35:34 +00:00
Copy Link
				publicUrl = url + href,
```suggestion publicUrl = url + href, ```
Koitharu (Migrated from github.com) commented 2021-05-15 16:35:52 +00:00
Copy Link
				publicUrl = url + href,
```suggestion publicUrl = url + href, ```
Koitharu commented 2021-05-15 16:38:58 +00:00 (Migrated from github.com)
Copy Link

Thanks for great job, than more sources then better

Thanks for great job, than more sources then better
👍 1
ztimms73 commented 2021-05-15 17:10:53 +00:00 (Migrated from github.com)
Copy Link

Oh, great, now I understand better what and how to do, this is my first time writing a parser, thank you, I will continue to try to help the project with development

Oh, great, now I understand better what and how to do, this is my first time writing a parser, thank you, I will continue to try to help the project with development
ztimms73 (Migrated from github.com) reviewed 2021-05-15 17:48:52 +00:00
ztimms73 (Migrated from github.com) reviewed 2021-05-15 19:07:51 +00:00
Koitharu (Migrated from github.com) reviewed 2021-05-16 05:14:34 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ztimms73
Koitharu
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 feature request
help wanted
Extra attention is needed
 invalid
This doesn't seem right
 meta
question
Further information is requested
 scope:downloader
scope:reader
scope:tracker
upstream issue
ux
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Koitharu Xtimms
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KotatsuApp/Kotatsu#30
Delete Branch "sources"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?