From 3c23bf7ec9e759806cf7fccc6fc6b6a4a5f51c58 Mon Sep 17 00:00:00 2001
From: Koitharu <nvasya95@gmail.com>
Date: Thu, 3 Nov 2022 18:00:19 +0200
Subject: [PATCH] Remove DialogWhenLarge theme

---
 app/src/main/AndroidManifest.xml              | 10 ++----
 .../koitharu/kotatsu/base/ui/BaseActivity.kt  |  1 -
 app/src/main/res/values-large/themes.xml      | 34 -------------------
 app/src/main/res/values/themes.xml            |  2 --
 4 files changed, 3 insertions(+), 44 deletions(-)
 delete mode 100644 app/src/main/res/values-large/themes.xml

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 1183591b1..44357e3d1 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -108,8 +108,7 @@
 		<activity
 			android:name="org.koitharu.kotatsu.widget.shelf.ShelfConfigActivity"
 			android:exported="true"
-			android:label="@string/manga_shelf"
-			android:theme="@style/Theme.Kotatsu.DialogWhenLarge">
+			android:label="@string/manga_shelf">
 			<intent-filter>
 				<action android:name="android.appwidget.action.APPWIDGET_CONFIGURE" />
 			</intent-filter>
@@ -127,12 +126,9 @@
 		<activity
 			android:name="org.koitharu.kotatsu.download.ui.DownloadsActivity"
 			android:label="@string/downloads"
-			android:launchMode="singleTop"
-			android:theme="@style/Theme.Kotatsu.DialogWhenLarge" />
+			android:launchMode="singleTop" />
 		<activity android:name="org.koitharu.kotatsu.image.ui.ImageActivity" />
-		<activity
-			android:name="org.koitharu.kotatsu.favourites.ui.categories.edit.FavouritesCategoryEditActivity"
-			android:theme="@style/Theme.Kotatsu.DialogWhenLarge" />
+		<activity android:name="org.koitharu.kotatsu.favourites.ui.categories.edit.FavouritesCategoryEditActivity" />
 		<activity
 			android:name="org.koitharu.kotatsu.sync.ui.SyncAuthActivity"
 			android:label="@string/sync" />
diff --git a/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseActivity.kt b/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseActivity.kt
index 08964f6bd..1d0954317 100644
--- a/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseActivity.kt
+++ b/app/src/main/java/org/koitharu/kotatsu/base/ui/BaseActivity.kt
@@ -53,7 +53,6 @@ abstract class BaseActivity<B : ViewBinding> :
 		EntryPointAccessors.fromApplication(this, BaseActivityEntryPoint::class.java).inject(this)
 		val isAmoled = settings.isAmoledTheme
 		val isDynamic = settings.isDynamicTheme
-		// TODO support DialogWhenLarge theme
 		when {
 			isAmoled && isDynamic -> setTheme(R.style.Theme_Kotatsu_Monet_Amoled)
 			isAmoled -> setTheme(R.style.Theme_Kotatsu_Amoled)
diff --git a/app/src/main/res/values-large/themes.xml b/app/src/main/res/values-large/themes.xml
deleted file mode 100644
index 56e1ed965..000000000
--- a/app/src/main/res/values-large/themes.xml
+++ /dev/null
@@ -1,34 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-	<style name="Theme.Kotatsu.DialogWhenLarge">
-		<item name="windowFixedWidthMajor">@dimen/abc_dialog_fixed_width_major</item>
-		<item name="windowFixedWidthMinor">@dimen/abc_dialog_fixed_width_minor</item>
-		<item name="windowFixedHeightMajor">@dimen/abc_dialog_fixed_height_major</item>
-		<item name="windowFixedHeightMinor">@dimen/abc_dialog_fixed_height_minor</item>
-		<item name="android:windowElevation">@dimen/abc_floating_window_z</item>
-		<item name="android:colorBackground">?attr/colorBackgroundFloating</item>
-		<item name="android:colorBackgroundCacheHint">@null</item>
-
-		<item name="android:windowFrame">@null</item>
-		<item name="android:windowTitleStyle">@style/RtlOverlay.DialogWindowTitle.AppCompat</item>
-		<item name="android:windowTitleBackgroundStyle">@style/Base.DialogWindowTitleBackground.AppCompat</item>
-		<item name="android:windowBackground">@drawable/abc_dialog_material_background</item>
-		<item name="android:windowIsFloating">true</item>
-		<item name="android:backgroundDimEnabled">true</item>
-		<item name="android:windowContentOverlay">@null</item>
-		<item name="android:windowAnimationStyle">@style/Animation.AppCompat.Dialog</item>
-		<item name="android:windowSoftInputMode">stateUnspecified|adjustResize</item>
-
-		<item name="windowActionBar">false</item>
-		<item name="windowActionModeOverlay">true</item>
-
-		<item name="listPreferredItemPaddingLeft">24dip</item>
-		<item name="listPreferredItemPaddingRight">24dip</item>
-
-		<item name="android:listDivider">@null</item>
-
-		<item name="android:buttonBarStyle">@style/Widget.AppCompat.ButtonBar.AlertDialog</item>
-		<item name="android:borderlessButtonStyle">@style/Widget.AppCompat.Button.Borderless</item>
-		<item name="android:windowCloseOnTouchOutside">true</item>
-	</style>
-</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml
index 1f67c8f18..5b27f6044 100644
--- a/app/src/main/res/values/themes.xml
+++ b/app/src/main/res/values/themes.xml
@@ -86,8 +86,6 @@
 	<!--== Default Theme ==-->
 	<style name="Theme.Kotatsu" parent="Base.Theme.Kotatsu" />
 
-	<style name="Theme.Kotatsu.DialogWhenLarge" />
-
 	<!-- Monet theme only support S+ -->
 	<style name="Theme.Kotatsu.Monet" />