From 0f97d29f6ac99b95b939117cefb2b87a7bb4f2f2 Mon Sep 17 00:00:00 2001 From: Koitharu Date: Tue, 23 Jul 2024 10:53:38 +0300 Subject: [PATCH] Fix CloudFlare activity crash (close #982) --- .../browser/cloudflare/CloudFlareActivity.kt | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/app/src/main/kotlin/org/koitharu/kotatsu/browser/cloudflare/CloudFlareActivity.kt b/app/src/main/kotlin/org/koitharu/kotatsu/browser/cloudflare/CloudFlareActivity.kt index 68daa3c2d..28c2f47d6 100644 --- a/app/src/main/kotlin/org/koitharu/kotatsu/browser/cloudflare/CloudFlareActivity.kt +++ b/app/src/main/kotlin/org/koitharu/kotatsu/browser/cloudflare/CloudFlareActivity.kt @@ -55,7 +55,11 @@ class CloudFlareActivity : BaseActivity(), CloudFlareCal setDisplayHomeAsUpEnabled(true) setHomeAsUpIndicator(materialR.drawable.abc_ic_clear_material) } - val url = intent?.dataString.orEmpty() + val url = intent?.dataString + if (url.isNullOrEmpty()) { + finishAfterTransition() + return + } cfClient = CloudFlareClient(cookieJar, this, url) viewBinding.webView.configureForParser(intent?.getStringExtra(ARG_UA)) viewBinding.webView.webViewClient = cfClient @@ -63,12 +67,7 @@ class CloudFlareActivity : BaseActivity(), CloudFlareCal onBackPressedDispatcher.addCallback(it) } CookieManager.getInstance().setAcceptThirdPartyCookies(viewBinding.webView, true) - if (savedInstanceState != null) { - return - } - if (url.isEmpty()) { - finishAfterTransition() - } else { + if (savedInstanceState == null) { onTitleChanged(getString(R.string.loading_), url) viewBinding.webView.loadUrl(url) }